Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Decaffeinated Build #324

Merged
merged 14 commits into from
Nov 2, 2024
Merged

Updating Decaffeinated Build #324

merged 14 commits into from
Nov 2, 2024

Conversation

paul90
Copy link
Member

@paul90 paul90 commented Sep 7, 2024

This is a work in progress, commits are in bite sized chunks to help with explaining the changes.

Before replacing Grunt/Browserify build process, replace Node:events (f009685) and Node:url (6afcaf0) with their browser equivalents.

Update the node versions used in the test action, and modify .gitignore, pre-empting some of the changes happening next. (930c000) and (db6301a)

@paul90 paul90 marked this pull request as ready for review September 7, 2024 15:12
@paul90
Copy link
Member Author

paul90 commented Sep 7, 2024

Update github actions so they run on push and PRs associated with the decaffeinate branch.

Remember to modify this when renaming the branches later.

@paul90
Copy link
Member Author

paul90 commented Sep 7, 2024

Replacing grunt/browserify with esbuild.

This gives javascript map files that work, so only need the minified build.

To build run npm run build.
To run the in browser test npm run runtests, and npm run test for those that can be run in the terminal.

The build process creates a metafile meta-client.json, that can be uploaded to esbuild: Bundle Size Analyzer to visualize the contents of the build.

@paul90
Copy link
Member Author

paul90 commented Sep 7, 2024

Update the version of mocha that is included in the client/test directory (previous version was ancient, at least 9 years old!).

A small associated change from global.wiki to globalThis.wiki in two of the test files.

@paul90
Copy link
Member Author

paul90 commented Sep 7, 2024

And a script to update the authors file npm run update-authors.

I have left decaffeinate <[email protected]> as a contributor, as it marks a significant point in history.

@paul90
Copy link
Member Author

paul90 commented Sep 7, 2024

Modify npm run build to run tests before building the client and test client. This makes it more like grunt build.

- the move broke the server, which requires `wiki-client/lib/resolve` and `wiki-client/lib/synopsis`
Copy link
Member

@nrn nrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

paul90 added a commit that referenced this pull request Oct 31, 2024
co-authored-by: Ward Cunningham <[email protected]>
Co-authored-by: Eric Dobbs <[email protected]>
@paul90 paul90 merged commit d9dff17 into decaffeinate Nov 2, 2024
3 checks passed
@paul90 paul90 deleted the denode branch November 2, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants