addpkg: libredefender #384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-value
requested changes
Nov 19, 2021
| prepare() { | ||
| cd "${pkgname}-${pkgver}" | ||
| - cargo fetch --locked --target "$CARCH-unknown-linux-gnu" | ||
| + cargo fetch --locked --target "riscv64gc-unknown-linux-gnu" |
There was a problem hiding this comment.
I don't think it's a good idea to substitute the variables with specific values, which reduces the generality of PKGBUILD.
Comment on lines
+25
to
+26
| + cd ~/.cargo/registry/src/github.com-1ecc6299db9ec823/nix-0.17.0/src/sys/ptrace | ||
| + patch -Np1 -i "${srcdir}/fix_ptrace_enum.patch" |
There was a problem hiding this comment.
nix-0.23.0is available and compatible with RISC-V, please remove the patch and bump the dependency instead.
| unsafe impl Sync for Engine {} | ||
|
|
||
| -fn map_scan_result(result: cl_error_t, virname: *const i8) -> Result<ScanResult, ClamError> { | ||
| +fn map_scan_result(result: cl_error_t, virname: *const u8) -> Result<ScanResult, ClamError> { |
There was a problem hiding this comment.
Are these changes compatible with x86_64? I really don't think that it's the source of the problem, could you please explain the reasons for this patch further?
|
Any updates? |
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Aug 10, 2023
Apply upstream char fix. Supersedes felixonmars#384.
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Aug 10, 2023
Apply upstream char fix. Supersedes felixonmars#384.
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Aug 10, 2023
Apply upstream char fix. Supersedes felixonmars#384.
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Aug 10, 2023
Apply upstream char fix. Supersedes felixonmars#384.
felixonmars
pushed a commit
that referenced
this pull request
Aug 13, 2023
Apply upstream char fix. Supersedes #384.
|
Superseded by #2895 , closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.