Also handle non-numeric, non-list, non-string coords

felt · Aug 30, 2024 · 2c7a048 · 2c7a048
1 parent e0aed25
commit 2c7a048
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/geo/json/decoder.ex b/lib/geo/json/decoder.ex
@@ -275,4 +275,8 @@ defmodule Geo.JSON.Decoder do
         raise ArgumentError, "expected a numeric coordinate, got: #{inspect(other)}"
     end)
   end
+
+  defp ensure_numeric(other) do
+    raise ArgumentError, "expected a numeric coordinate, got: #{inspect(other)}"
+  end
 end
diff --git a/test/geo/json_test.exs b/test/geo/json_test.exs
@@ -431,6 +431,23 @@ defmodule Geo.JSON.Test do
     end
   end
 
+  test "Decode rejects geometries with garbage coordinates" do
+    json = """
+      {
+        "properties": {},
+        "geometry": {
+          "type": "Point",
+          "coordinates": {"x": 1.0, "y": 2.0}
+        },
+        "type": "Feature"
+      }
+    """
+
+    assert_raise ArgumentError, fn ->
+      Jason.decode!(json) |> Geo.JSON.decode!()
+    end
+  end
+
   property "encodes and decodes back to the correct Point struct" do
     check all(
             x <- float(),