Travis ci #249
Merged
Travis ci #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
이번 노동톤때에 리뷰할게요 죄송해요 시간이 안나네요 |
|
앗 네 그럴려고 올린거였어요 |
simnalamburt
force-pushed
the
travis-ci
branch
from
b85aebb to
86108c2
Compare
lens0021
force-pushed
the
travis-ci
branch
2 times, most recently
from
88fa945 to
9219570
Compare
|
(참고)이 PR의 체크 실패는 install-extensions.php의 린트 때문에 일어난 것이나 해당 파일은 없어질 예정이므로 무시해도 됩니다. |
simnalamburt
force-pushed
the
travis-ci
branch
3 times, most recently
from
822403f to
f07e991
Compare
simnalamburt
requested changes
Feb 1, 2019
lens0021
force-pushed
the
travis-ci
branch
2 times, most recently
from
40f2c66 to
5a08ea2
Compare
simnalamburt
requested changes
Feb 2, 2019
simnalamburt
force-pushed
the
travis-ci
branch
from
3404a4a to
c7da026
Compare
simnalamburt
approved these changes
Feb 2, 2019
simnalamburt
force-pushed
the
travis-ci
branch
2 times, most recently
from
e1fdaea to
846b3cc
Compare
1. Create '.travis.yml' 2. Update gitignore and dockerignore files 3. Create composer.json and composer.lock 4. Import .phpcs.xml from https://github.com/wikimedia/mediawiki/blob/REL1_31/.phpcs.xml 5. Update editorconfig for composer.lock and phpcs.xml
simnalamburt
force-pushed
the
travis-ci
branch
2 times, most recently
from
7c9dab9 to
07075b0
Compare
It is too much to test the external codes
1. Don't lint 'secret.php' 2. Preperation steps are 'before_script' phase not 'install' phase 3. Reorder some steps 4. Don't wait until 'mediawiki_parsoid' and 'mediawiki_fastcgi' are up 5. Add comments
1. Simplify multiple codes 2. Remove 'sleep 60'
1. Made it not to ignore LocalSettings.php 2. Removed redundant rules
1. Add a badge of Travis CI 2. Mention 'composer test' 3. Organize instructions
simnalamburt
force-pushed
the
travis-ci
branch
from
07075b0 to
99d580f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #242