We prefer to use const when possible, so let's enforce it

That's simple enough to be handled internally

We still prefer to stay on 80, but slightly longer lines are still
allowed while it's an error to use something longer 110

It may imply looping through unwanted values, so let's avoid it.

This may be supported when using remote launcher actions

These information are only available when a widget is on the stage

These are safer because they perform an implicit existence check.

…an umounted one

…ound

We're already doing a check for handler app in vfunc_launch(), so
there's no need to go through the same via vfunc_get_commandline()

It's supposed to be a void method

Otherwise it won't be possible to retry

GVfs implementations of GFile could cause the shell to hang while querying
the file infos, making the whole UI to freeze, and such actions can't be
cancelled, even if that's running in external processes.

To avoid this to happen, we need to use the async API and limit its
execution time to handle failures gracefully.

In case we also cache the last valid handler applications so that in case we
can re-use it on timeouts.

LP: #1997264

Sadly we can't use the new-window action directly because it does not
support adding further arguments.

Ensure we drop the timeouts on we have to launch the default locations
handlers.

Closes: #1929

Even though that's only used in a delayed promise, it's still better to
go in order.

Dispose the window previews close button left or right depending on the
button layout settings.

Closes: #1918

That's used in theming

Related-to: #1949

Needed to support GNOME 44.

This happens implicitly, but still better to do it explicitly too

Closes: #872

Support monitoring notifications that are still around in the shell
notification tray and use it to increase the icon indicators count.

This is not visible in case we are in do-not-disturb mode.

Closes: #1861, #20

Closes: #1329

…imes

It's quite unlikely that the handler changes a lot during execution
anyways.

Instead of enforcing a minimum window height of 850. The height is
now resizable.

Fixes: #1975

Increases the size fo the small screens, ensuring it can be visible in
most cases.

Closes: #1969

…tions

Otherwise the badge will be always visible even for those applications
that have been acked by the user.

… them

… only

Counters could have been disabled together with the unity-API values
before, now allow to be more precise.

…summed

By default we don't override the applications-provided count anymore,
while disabling it the two values are summed.

There's no point to do all the monitoring if it has been disabled
explicitly or because we're i dnd mode.

So we get the GAppInfo handling for context data and startup notification.

Closes: #1952

Getting the default location handler has to be a sync operation because
the shell uses a sync operations to launch applications.
However, this may have lead to hanging the shell, making it unresponsive.

We handled this within the shell itself, but to get it working we had to
keep keep the main loop busy, leading to other issues (see LP: #2013070)

As per this, use an external helper that queries the files paths so that
we don't have to make the shell main loop to iterate, but all this is done
in an external process that we call still synchronously but with a minimal
timeout so that the main session won't ever hang.

Improves fix for: #1949
LP: #2013070

It means we don't have matching windows anyways, and this could happen for
unmounted volumes

There's no need to keep our injected methods and signal connections
around when the startup animation has completed.

…mation

During startup animation the shell may receive a monitors-changed event,
in this case the startup animation events are never triggered because
the background loaded signal is never emitted.

To prevent this, re-implement the update background code during the
layout _prepareStartupAnimation so that we can catch monitor update
events and react accordingly.

See: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2763

LP: #2019751

LP: #2019751

We should initialize the object before anything else

Closes: #1746

… mode

See: #1746

intellihide: add dropdown menu to handled window types

Closes: #1887

Avoid using internal functions, since we have public LayoutManager
methods we can use instead.

We were allocating the ControlsManagerLayout using the whole work area
geometry but then in the auto-hide mode we were reducing the size of the
available area again, creating problems when the available space was
reduced. Leading to non-clickable or activatable search results.

To prevent this, perform layout allocation using the available space
even when the dock is in autohide mode.

Closes: #1612
LP: #1979096

We used different behavior depending on the state, but we can just be
consistent and reduce the vertical space used in the same way

… thumbs

When using a floating show apps icon setup, it needs to be at the same
level of the dash box, but we can't use the same container because
upstream code only uses that for application icons, and this assumption
may break things such as DnD and potentially other things.

So move things in a new container.

Closes: #2010

The separator may be wrongly computed as an extra icon item,
causing new items being positioned in the wrong place.

This is clearly visible when running a new application, that ends
up being added as the one before the last one, instead of as the
last one.

By temporary removing the separator element we avoid having to
consider the special case all the times when doing the icons
positioning math, instead we can just add it back once we're
done.

See: #2010 (comment)

LP: #2017523

Just get the actual number of icons we've in the box minus the ones
we're going to remove.

So that our math is right about when to show the separator

Use better syntax

…e separator"

This reverts commit 50d7a98.

…rator

When a favorite is removed the separator should be shifted accordingly,
so use the old separator position as reference