Azure Cosmos multiple stores per container #2953
Conversation
Signed-off-by: Ryan Levick <[email protected]>
Signed-off-by: Ryan Levick <[email protected]>
rylev
force-pushed
the
cosmos-multistore-container
branch
from
c6d9b1d to
40dfc1e
Compare
Signed-off-by: Ryan Levick <[email protected]>
| pub fn new() -> Self { | ||
| Self::default() | ||
| /// | ||
| /// When `app_id` is provided, the store will a partition key of `$app_id/$store_name`, |
There was a problem hiding this comment.
| /// When `app_id` is provided, the store will a partition key of `$app_id/$store_name`, | |
| /// When `app_id` is provided, the store will be a partition key of `$app_id/$store_name`, |
| if let Some(pk) = partition_key { | ||
| query.push_str(" AND c.partition_key='"); | ||
| query.push_str(pk); | ||
| query.push('\'') |
There was a problem hiding this comment.
What is the purpose of this trailing \?
There was a problem hiding this comment.
We're pushing single quote (') on to the end of the query (to close the single quote that comes right after the =). The \ escapes the ' character since characters are always themselves enclosed in ''.
| /// An optional partition key to use for all operations. | ||
| /// | ||
| /// If the partition key is not set, the store will use `/id` as the partition key. | ||
| partition_key: Option<String>, | ||
| } |
There was a problem hiding this comment.
Is there a reason we don't set partition here instead of suffixing the request? Are we anticipating gets across stores?
async fn get_pair(&self, key: &str) -> Result<Option<Pair>, Error> {
let query = self
.client
.query_documents(Query::new(self.get_query(key)))
.query_cross_partition(true)
.max_item_count(1);There was a problem hiding this comment.
I'm not sure I understand your question. Can you reformulate it?
There was a problem hiding this comment.
I realized what my issue was. The implementation assumes that the container "Partition Key" is set to /partition_key. You mention this in the description but i skipped over it accidentally. Maybe naming the partition key something else such as "store_identifier" would help.
Signed-off-by: Ryan Levick <[email protected]>
|
I've switched from the |
Fixes #2951
This adds support in the Azure Cosmos key-value implementation for storing multiple key-value stores in a single Azure Cosmos container.
IMPORTANT: This currently does not change the Spin CLI experience at all. Users of Spin CLI continue to have the 1 to 1 relationship between containers and key-value stores. This only allows Spin runtime embedders the ability to have many stores per containers. We can consider changing the default behavior for the Spin CLI in the future, but this might need to be at a major version change.
For embedders who provide an
app_idto theKeyValueAzureCosmos, stores will be created in the supplied container and each key/value pair will include a partition_key field in the form of "$app_id/$store_id".cc @devigned