Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental bugs #11

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Accidental bugs #11

merged 2 commits into from
Jan 26, 2021

Conversation

github-learning-lab[bot]
Copy link
Contributor

Now that your release is finalized, we have a confession to make... somewhere in our recent update, I made a mistake and introduced a bug. Instead of changing the text colors to green, we changed the whole background.

Sometimes GitHub Pages takes a few minutes to update. Your page might not immediately show the recent updates you've made.

image

"Hotfixes", or a quick fix to address a bug in software, are a normal part of development. Oftentimes you'll see application updates whose only description is "bug fixes".

When bugs come up after you release a version, you'll need to address them.

We've already created this branch, pull request, and suggested a fix. The suggested change will be merged into the main branch. Later we will cherry-pick the hotfix commits into the release branch.

Step 12: Approve a hotfix pull request

Submit a hotfix by applying the suggested change and approving this PR.

⌨️ Activity: Apply the suggestion

  1. Click Commit suggestion
  2. Enter a commit message
  3. Click Commit changes
  4. Approve this pull request

I'll respond below with your next steps

game.js Outdated Show resolved Hide resolved
I think it will look better now, good work!

Co-authored-by: github-learning-lab[bot] <37936606+github-learning-lab[bot]@users.noreply.github.com>
@github-learning-lab github-learning-lab bot merged commit d1afb04 into main Jan 26, 2021
@github-learning-lab
Copy link
Contributor Author

Your fix is now on main! This ensures that any new code isn't based on our bug.

Let's backport those changes to the branch with release v1.0.


Go to the next pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants