Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return this from destroy() #855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielroe
Copy link

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

This simply returns this from destroy() - quite a minor change but which brings the implemenation of Duplex into line with current Node implementation.

Which issue (if any) does this pull request address?

For consistency with Node readable stream implementation, destroy() should return this - https://nodejs.org/api/stream.html#readabledestroyerror

Is there anything you'd like reviewers to focus on?

Context: DefinitelyTyped/DefinitelyTyped#57473

Copy link

@Arcuman Arcuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

@rprata
Copy link

rprata commented Apr 22, 2022

News about this PR?

@ViniciusFXavier
Copy link

@feross pls you can review this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants