Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra umlauts on a and e in english words #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thement
Copy link

@thement thement commented Nov 9, 2022

No description provided.

@shrugalic
Copy link
Contributor

shrugalic commented Dec 31, 2022

Oh hey, I just saw this PR. This extra umlauts issue also caught my eye in my PR, where I asked what the intention of the extra umlauts is, or weather they should be removed or not.

I'm happy to see you already did this change, however I notice it is incomplete: there are also extra umlauts on i, o and u – that is there are ï, ö and ü characters.

Given there was no reaction to your PR at all so far, I would understand your reluctance to fix that as well. I wonder if pinging the author on another channel would help? Though I'd think PRs would be high on the list of things to automatically look at, and it's just life getting in the way or something.

Edit: "life getting in the way" seems to be the case, according to this README. Given that was 7 months ago I'll send an email to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants