Rewrite Use Import subchapter #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dajamante
reviewed
Aug 9, 2023
| with :t:`public visibility` prefixed by its :t:`simple path prefix` into | ||
| :t:`scope`. | ||
| exported by the :t:`module` or :t:`enum` its :t:`import path prefix` resolves to | ||
| into :t:`scope`. |
There was a problem hiding this comment.
This sentence is quite hard to understand: "
"A glob import is a use import that brings all entities exported by the module or enum its import path prefix resolves to into scope."
Do you mean it brings all modules pointed to by the import path prefix into scope?
There was a problem hiding this comment.
it brings all entities into scope that are exported in the module or enum that the path prefix resolves to, that is
foo::bar::*
imports everything from the foo::bar module (or enum)
There was a problem hiding this comment.
If it is clear to you, then that is good enough.
Dajamante
approved these changes
Aug 9, 2023
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Fixes #323