Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ledger-cosmos-go to v0.12.4 (macOS IOKit lib location change) #171

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

pbukva
Copy link
Contributor

@pbukva pbukva commented Oct 24, 2023

This is support for Ledger HW wallets on macOS Ventura v13.x where location of IOKit library changed - see the following PR: OS X enumerate fix: also look for IOKit in /System/Library/Frameworks #15.

This is support for Ledger HW wallets on macOS Ventura v13.6 with
Xcode v15.0.1 and command-line tools v15.0.0.0.1.1694021235.
@pbukva pbukva self-assigned this Oct 24, 2023
@pbukva pbukva requested review from Jonathansumner, MissingNO57 and ejfitzgerald and removed request for Jonathansumner October 24, 2023 18:18
@pbukva pbukva changed the title Upgrage ledger-cosmos-go to v0.13.2 (from v0.11.1) Upgrade ledger-cosmos-go to v0.13.2 (from v0.11.1) Oct 24, 2023
@pbukva pbukva changed the title Upgrade ledger-cosmos-go to v0.13.2 (from v0.11.1) feat: Upgrade ledger-cosmos-go to v0.13.2 (from v0.11.1) Oct 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #171 (d01ce56) into main (43f6e51) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   60.51%   60.52%           
=======================================
  Files         599      599           
  Lines       38884    38884           
=======================================
+ Hits        23532    23533    +1     
+ Misses      13372    13371    -1     
  Partials     1980     1980           
Files Coverage Δ
x/mint/abci.go 0.00% <0.00%> (ø)
x/mint/keeper/grpc_query.go 56.25% <0.00%> (ø)

... and 1 file with indirect coverage changes

@pbukva pbukva changed the title feat: Upgrade ledger-cosmos-go to v0.13.2 (from v0.11.1) fix: macOS usb dev enumeration ([email protected]) Oct 24, 2023
@pbukva pbukva changed the title fix: macOS usb dev enumeration ([email protected]) fix: Upgrage ledger-cosmos-go to v0.12.4 (macOS IOKit lib) Oct 24, 2023
@pbukva pbukva marked this pull request as ready for review October 26, 2023 11:45
@pbukva pbukva changed the title fix: Upgrage ledger-cosmos-go to v0.12.4 (macOS IOKit lib) fix: ledger-cosmos-go to v0.12.4 (macOS IOKit lib location change) Oct 26, 2023
@pbukva pbukva merged commit 09cf7ba into fetchai:main Oct 27, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants