Reduce logging to help loki (#2405)

fetchai · Feb 7, 2020 · 02c2621 · 02c2621
1 parent 2f24e12
commit 02c2621
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/libs/ledger/src/miner/basic_miner.cpp b/libs/ledger/src/miner/basic_miner.cpp
@@ -164,7 +164,7 @@ void BasicMiner::GenerateBlock(Block &block, std::size_t num_lanes, std::size_t
   // cache the size of the mining pool
   std::size_t const pool_size_before = mining_pool_.size();
 
-  FETCH_LOG_INFO(LOGGING_NAME, "Starting block packing. Pool Size: ", pool_size_before);
+  FETCH_LOG_DEBUG(LOGGING_NAME, "Starting block packing. Pool Size: ", pool_size_before);
 
   // determine how many of the threads should be used in this block generation
   auto const num_threads = Clip3<std::size_t>(mining_pool_.size() / 1000u, 1u, max_num_threads_);

diff --git a/libs/ledger/src/storage_unit/transaction_store_sync_protocol.cpp b/libs/ledger/src/storage_unit/transaction_store_sync_protocol.cpp
@@ -160,12 +160,6 @@ TSSP::TxArray TransactionStoreSyncProtocol::PullObjects(service::CallContext con
     }
   }
 
-  if (!ret.empty())
-  {
-    FETCH_LOG_INFO(LOGGING_NAME, "Lane ", lane_, ": PullObjects: Sending back ", ret.size(),
-                   " TXs");
-  }
-
   return ret;
 }
 
@@ -211,6 +205,12 @@ TSSP::TxArray TransactionStoreSyncProtocol::PullSpecificObjects(DigestSet const
     }
   }
 
+  if (!ret.empty())
+  {
+    FETCH_LOG_INFO(LOGGING_NAME, "Lane ", lane_, ": PullSpecificObjects: Sending back ", ret.size(),
+                   " TXs");
+  }
+
   return ret;
 }
 

diff --git a/libs/ledger/src/storage_unit/transaction_store_sync_service.cpp b/libs/ledger/src/storage_unit/transaction_store_sync_service.cpp
@@ -463,6 +463,7 @@ TransactionStoreSyncService::State TransactionStoreSyncService::OnResolvingObjec
   if (counts.failed != 0u)
   {
     FETCH_LOG_WARN(LOGGING_NAME, "Lane ", cfg_.lane_id, ": ", "Failed promises: ", counts.failed);
+    pending_objects_.DiscardFailures();
   }
 
   return State::TRIM_CACHE;