support escaped property name #70
Conversation
|
*Ruff* 🐶 I wasn't able to find any Docker Compose files in your repository at any of the given paths in the Files checked:
What is this?Pull Dog is a GitHub app that makes test environments for your pull requests using Docker, from a Visit our website to learn more. Commands
TroubleshootingNeed help? Don't hesitate to file an issue in our repository Configuration {"isLazy":false,"dockerComposeYmlFilePaths":["docker-compose.yml"],"expiry":"00:00:00","conversationMode":"singleComment"}Trace ID |
| @@ -189,6 +189,7 @@ | |||
| result += this.getAttributesRegex(captureAttributes); | |||
| result += this.getModifiersRegex(captureModifiers); | |||
| result += this.getGenericTypeNameRegex(captureReturnType, false, false, false, false); | |||
| result += "[@]?"; | |||
There was a problem hiding this comment.
I think it should be added as part of the getGenericTypeNameRegex method. Also, I don't think the square brackets are needed? 🤔😊
There was a problem hiding this comment.
I think it should be added as part of the getGenericTypeNameRegex method. Also, I don't think the square brackets are needed? 🤔😊
Does that mean '@' should be considered as a part of typename instead of property name?
Attempt to address #69
Added optional
[@]?pattern ingetPropertyRegex()ofRegExHelperand added some tests. Not sure if I did this right, please review.