Fix rpmKeyringModify with RPMKEYRING_REPLACE

We need to both delete the old key and add the new one.
ffesti · Nov 26, 2024 · 8eff293 · 8eff293
1 parent 0d5f27e
commit 8eff293
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/rpmio/rpmkeyring.cc b/rpmio/rpmkeyring.cc
@@ -167,7 +167,8 @@ int rpmKeyringModify(rpmKeyring keyring, rpmPubkey key, rpmKeyringModifyMode mod
 	rpmPubkeyFree(item->second);
 	keyring->keys.erase(item);
 	rc = 0;
-    } else if ((item == range.second && mode == RPMKEYRING_ADD) || mode == RPMKEYRING_REPLACE) {
+    }
+    if ((item == range.second && mode == RPMKEYRING_ADD) || mode == RPMKEYRING_REPLACE) {
 	int subkeysCount = 0;
 	rpmPubkey *subkeys = rpmGetSubkeys(key, &subkeysCount);
 	keyring->keys.insert({key->keyid, rpmPubkeyLink(key)});