Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PYTHONPATH for circus universal #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

noonedeadpunk
Copy link

Currently PYTHONPATH is hardcoded and assumption about
python version is made. While its recommended to use systemd,
we still can fix circus by retrieving venv lib path.
As a package location we pick gunicorn as smth we expect to
be present anyway. As a result we will get
{{ lib_path }}/gunicorn/init.py so we apply dirname twice to get
just lib_path that can be re-used later on

Dmitriy Rabotyagov and others added 3 commits July 8, 2021 10:22
Currently PYTHONPATH is hardcoded and assumption about
python version is made. While its recommended to use systemd,
we still can fix circus by retrieving venv lib path.
As a package location we pick gunicorn as smth we expect to
be present anyway. As a result we will get
{{ lib_path }}/gunicorn/__init__.py so we apply dirname twice to get
just lib_path that can be re-used later on
Copy link
Owner

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the best way to do things. :)

What do you think of the alternate approach in 8e69482?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants