Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Update search tests to use count if total not provided in bundle #177

Open
wants to merge 1 commit into
base: r4
Choose a base branch
from
Open

Update search tests to use count if total not provided in bundle #177

wants to merge 1 commit into from

Conversation

gabcbrown
Copy link

As mentioned in #140 , the total field of a bundle can be provided in search results but is not required. This PR updates the Search and Sprinkler Search test suites to use a count of the resources in the bundle if no total is provided, just as #159 updated the History test suites. It was also mentioned in the discussion of PR 159 that pagination is required to get an accurate count, but since the tests in question aren't querying large numbers of resources this is reasonably left to further implementation.

@gabcbrown
Copy link
Author

@arscan let me know if there's anything else I can do to make this PR ready. I have a few other things I'd like to contribute too.

@gabcbrown
Copy link
Author

Hi @arscan, @jawalonoski, please let me know if this project is being actively maintained. I have been using Crucible extensively, and I think there's a lot of great work here! I am finding bugs in the plan_executor, especially around generating resources and R3<=>R4 differences, that I would like to help fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant