Allow renaming of nodes in editor #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only the title of the node should be changed or graph gets messed up
unsure what this node does at the moment
♻ cleaned up files, removed methods from children that were just overriding their parents
Noted differences between fork and main branch and planned features
|
We can probably close #51 with this PR as well 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored quite a bit in this pull request. If you would like me to keep it separate and in my fork that is fine! This PR allows a user to rename their nodes how they would like similar to #51 but doing what they did didn't seem to play well with the editor. Also added undo and redo functionality with the BTree editor and renaming nodes. Refactored most of the editor nodes to inherit from a base class so it is easier to do changes to all of them (a lot of code was duplicated between each ui node). It persists through relaunches and shows in the debugger as well. If you have any questions let me know!
I had done a PR for this previously but closed it since it wasn't completely finished. I've been using these changes in my main project and have had no issues so far. Thanks!