feat(user-action-details): add AccountNumberUserAction #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cajubelt
changed the title
jophish
approved these changes
Nov 14, 2023
fiatconnect-api.md
Outdated
| institutionName: `string`, | ||
| accountName: `string`, | ||
| accountNumber: `string`, | ||
| transactionReference: `string`, |
There was a problem hiding this comment.
Can this be made optional for providers that don't require this? I imagine many providers will be able to cross reference the account the payment is from with the one on file. You can add the provision that if it's present, it MUST be included in the actual transfer itself.
There was a problem hiding this comment.
sounds reasonable. updated
cajubelt
deleted the
cajubelt/bank-account-transfer-user-action-details
branch
cajubelt
added a commit
to fiatconnect/fiatconnect-types
that referenced
this pull request
Nov 15, 2023
…userActionDetailsSchema and type (#204) added to spec [here](fiatconnect/specification#102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen FiatConnect providers use the URLUserActionDetails schema and direct users to their own website just to explain to them that they need to send funds to the same CICO provider's bank account. This defies the intention of the UserActionDetails feature, which is supposed to give FiatConnect clients a chance to explain to users what steps are needed to complete a transfer in-- not just hand them off to complete arbitrary steps on some other website. This PR adds a UserActionDetails schema that should bridge the gap, allowing CICO providers to solicit a bank transfer from end-users without redirecting them to another website.