show env var, reset terminal mode #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe go ahead and AUTH to the ReadMe, as everyone is always looking for that one. |
|
oh, i forgot about that... just fixed the missing stuff in the actual help texts... i will add this near the top so it's easy to find |
fiatjaf
reviewed
Jan 12, 2025
| @@ -10,10 +10,21 @@ take a look at the help text that comes in it to learn all possibilities, but he | |||
| ### make a nostr event signed with the default key (`01`) | |||
|
|
|||
| ```shell | |||
| ~> nak event | |||
| {"id":"53443506e7d09e55b922a2369b80f926007a8a8a8ea5f09df1db59fe1993335e","pubkey":"79be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798","created_at":1698632644,"kind":1,"tags":[],"content":"hello from the nostr army knife","sig":"4bdb609c975b2b61338c2ff4c7ce91d4afe74bea4ed1601a62e1fd125bd4c0ae6e0166cca96e5cfb7e0f50583eb6a0dd0b66072566299b6007742db56278010c"} | |||
| ~> nak event {"id":"53443506e7d09e55b922a2369b80f926007a8a8a8ea5f09df1db59fe1993335e","pubkey":"79be667ef9dcbbac55a06295ce870b07029bfcdb2dce28d959f2815b16f81798","created_at":1698632644,"kind":1,"tags":[],"content":"hello from the nostr army knife","sig":"4bdb609c975b2b61338c2ff4c7ce91d4afe74bea4ed1601a62e1fd125bd4c0ae6e0166cca96e5cfb7e0f50583eb6a0dd0b66072566299b6007742db56278010c"} | |||
There was a problem hiding this comment.
why is this all in the same line now?
There was a problem hiding this comment.
because if you copy it, it won't run if you paste it, why else?
fiatjaf
reviewed
Jan 12, 2025
fiatjaf
reviewed
Jan 12, 2025
helpers_key.go
Outdated
| @@ -20,8 +22,8 @@ import ( | |||
| var defaultKeyFlags = []cli.Flag{ | |||
| &cli.StringFlag{ | |||
| Name: "sec", | |||
| Usage: "secret key to sign the event, as nsec, ncryptsec or hex, or a bunker URL", | |||
| DefaultText: "the key '1'", | |||
| Usage: "secret key to sign the event, as nsec, ncryptsec or hex, or a bunker URL, it is better to use the environment variable NOSTR_SECRET_KEY ", | |||
There was a problem hiding this comment.
I would prefer to keep a stable key rather than generating a random key each time, 1 is a reasonable choice
mleku
changed the title
closes fiatjaf#49 (cherry picked from commit 381526f)
# Conflicts: # helpers_key.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does all the things mentioned in the related issue
closes #49