Skip to content

Commit

Permalink
[docker] refs #27 Fixed a misspell
Browse files Browse the repository at this point in the history
  • Loading branch information
stdevYuniers committed Jan 20, 2019
1 parent 3c74a09 commit da38d54
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
11 changes: 7 additions & 4 deletions docker/images/dev-cli/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,18 +99,21 @@ $ docker build --build-arg IMAGE_FROM=$IMAGE_FROM \
-t "$IMAGE_NAME" .
```

If you want use Visual Studio Code as IDE, yo can change `IMAGE_FROM` to build it. **When base image use Visual Studio Code, you can use `VS_EXTENSIONS` build arg**
If you want use Visual Studio Code as IDE, you can change `IMAGE_FROM` to build it. **When base image use Visual Studio Code, you can use `VS_EXTENSIONS` build arg**

```sh
$ git clone https://github.com/simelo/libskycoin-dotnet.git && cd libskycoin-dotnet
$ IMAGE_FROM="simelotech/skycoindev-vscode:develop"
$ git submodule update --init --recursive
$ # Move to vscode folder to avoid file errors with vscode docker image
$ cd gopath/src/github.com/skycoin/skycoin/docker/images/dev-vscode/
$ IMAGE_FROM="skycoin/skycoindev-vscode:develop"
$ SOURCE_COMMIT=$(git rev-parse HEAD)
$ IMAGE_NAME=simelotech/libskycoin-dotnet:vscode
$ DOCKERFILE_PATH=docker/images/dev-cli/Dockerfile
$ docker build --build-arg IMAGE_FROM=$IMAGE_FROM \
$ docker build --build-arg IMAGE_FROM="$IMAGE_FROM"
--build-arg BDATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
--build-arg SCOMMIT=$SOURCE_COMMIT \
--build-arg VS_EXTENSIONS="ms-vscode.Go windmilleng.vscode-go-autotest" \
-f $DOCKERFILE_PATH \
-t "$IMAGE_NAME" .
```
```
6 changes: 3 additions & 3 deletions docker/images/dev-cli/hooks/push
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
docker push $IMAGE_NAME

if [ "$CACHE_TAG" == "develop" ]; then
docker push $DOCKER_REPO:dind
docker push $DOCKER_REPO:vscode
docker push $DOCKER_REPO:vscode-dind
docker push "$DOCKER_REPO:dind"
docker push "$DOCKER_REPO:vscode"
docker push "$DOCKER_REPO:vscode-dind"
fi

0 comments on commit da38d54

Please sign in to comment.