Skip to content

Commit

Permalink
Add Issue numbers to @todo comments
Browse files Browse the repository at this point in the history
  • Loading branch information
carstingaxion committed Oct 16, 2023
1 parent 6323658 commit 70cdefa
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 17 deletions.
9 changes: 5 additions & 4 deletions ft-network-sourcelinks.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public static function get_subscribed_events() : Array



// TEMP DISABLED, until sync works, read on down the code
// @todo #32 Re-ENABLE - TEMP DISABLED; until sync works, read on down the code
// 'after_setup_theme' => 'enable__on_setup_theme', // working


Expand Down Expand Up @@ -204,12 +204,13 @@ public function i18n()


/**
* @todo TEMPORARILY DISABLED
* @todo #32
* TEMPORARILY DISABLED
* but needed when sync/importing starts
* so we can assign different post_formats based on the
* so we can assign different post_formats based on the
* source_links post_format
*
*
*
* Note that you must call 'add_theme_support()' before the init hook gets called!
*
* A good hook to use is the after_setup_theme hook.
Expand Down
6 changes: 3 additions & 3 deletions inc/Network/Options/Preset__wpseo_social.php
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ function( $v, $k ) use ( &$_urls, $_social_links ) {
// clean up url as pseudo label
// so this makes
// https://instagram.com -> instagram
// @TODO

// @todo #25
// we have this string-cleaning now 3 times
//
// - plugins\ft-network-sourcelinks\src\block-editor\blocks\filtered-links\index.php#L90
Expand Down Expand Up @@ -179,7 +179,7 @@ public function pre_option_wpseo_social( array|bool $wpseo_social ) : array {

if ( isset( $_urls['pinterest'] ) && ( !isset( $wpseo_social['pinterest_url'] ) || empty( $wpseo_social['pinterest_url'] ))) {
$wpseo_social['pinterest_url'] = $_urls['pinterest'];
// @TODO add handling for post_meta 'pinterestverify'
// @TODO #26 add handling for post_meta 'pinterestverify'
}

if ( isset( $_urls['twitter'] ) && ( !isset( $wpseo_social['twitter_site'] ) || empty( $wpseo_social['twitter_site'] ))) {
Expand Down
8 changes: 4 additions & 4 deletions inc/Network/Post_Types/Post_Type__ft_link.php
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,8 @@ public static function get_readable_link( WP_Post|null $post = null ) {
if( null === $post )
global $post;

// @TODO

// @todo #25
// we have this string-cleaning now 3 times
//
// - plugins\ft-network-sourcelinks\src\block-editor\blocks\filtered-links\index.php#L90
Expand Down Expand Up @@ -421,8 +421,8 @@ public static function get_instance()


/**
* @todo Everything.
*
* @todo #27 Refactor __is_ft_link_privacy_relevant()
*
* [__is_ft_link_privacy_relevant description]
*
* @package [package]
Expand Down
2 changes: 1 addition & 1 deletion inc/Network/Taxonomies/Taxonomy__ft_link_shadow.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ protected function prepare_labels() : array
# Override the base names used for labels:
'singular' => __('Import Source','figurentheater'),
'plural' => __('Import Sources','figurentheater'),
'slug' => '' #TODO
'slug' => '' #TODO #28 Add documenatation on, why this is '' empty here ?!
];
}

Expand Down
7 changes: 4 additions & 3 deletions src/block-editor/blocks/filtered-links/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ function render_block( $attributes, $content, $block ) {
return '';


// TODO // not used at the moment, so it defaults to: div
// TODO #29 // consider using $attributes['tagName']
// which is not used at the moment, so it defaults to: ul
$tag_name = empty( $attributes['tagName'] ) ? 'ul' : $attributes['tagName'];

// get and merge wrapper attributes with text-align CSS class
Expand All @@ -78,8 +79,8 @@ function render_block( $attributes, $content, $block ) {
function( $link ) use ( $attributes )
{
// die(var_export([$_url,$link->post_content],true));
// @TODO

// @todo #25
// we have this string-cleaning now 3 times
//
// - plugins\ft-network-sourcelinks\src\block-editor\blocks\filtered-links\index.php#L90
Expand Down
2 changes: 1 addition & 1 deletion src/block-editor/blocks/simple-links/edit.js.BU
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function useLinkData() {
);

return useMemo( () => {
/*// TODO: Once the REST API supports passing multiple values to
/*// TODO: #30 Once the REST API supports passing multiple values to
// 'orderby', this can be removed.
// https://core.trac.wordpress.org/ticket/39037
const sortedPages = sortBy( pages, [ 'menu_order', 'title.rendered' ] );
Expand Down
2 changes: 1 addition & 1 deletion src/block-editor/blocks/social-links/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export default function Edit() {
[]
);

// @todo
// @todo #31
// check for more than one InnerBlocks
// and only then
// look for the links
Expand Down

0 comments on commit 70cdefa

Please sign in to comment.