Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup with disabled index provider #1604

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Aug 3, 2023

Fixes #1602

@dirkmc dirkmc marked this pull request as ready for review August 3, 2023 07:43
@LexLuthr
Copy link
Collaborator

LexLuthr commented Aug 4, 2023

No crashes with disabled provider
Screenshot 2023-08-04 at 2 20 27 PM

@LexLuthr LexLuthr merged commit e669dca into main Aug 4, 2023
@LexLuthr LexLuthr deleted the fix/disabled-index-prov branch August 4, 2023 12:42
@f8-ptrk
Copy link
Contributor

f8-ptrk commented Aug 4, 2023

can i merge that into 1.7.x branches without a problem?

@LexLuthr
Copy link
Collaborator

LexLuthr commented Aug 4, 2023

I think you can cherry-pick without any issues. Let me know if there are compatibility problems. We are planning to cut a patch release for this.

LexLuthr pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boostd start-up panic when IndexProvider.Enable == false
3 participants