Zellic remediation #66
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cross CBOR contracts
….sol Switched back to using deserializeBigInt for balance, locked, storage_price_per_epoch, provider_collateral, and client_collateral fields to fix deserialization issues and pass all tests.
- Replaced uint256 with uint64 for consistent buffer allocation in capacity calculation and initialization. - Added safety check to prevent array length overflow beyond uint64 limits. - Ensured proper serialization of new_control_addresses without potential truncation. Addresses buffer allocation type mismatch warning.
- Replaced all `assert` statements with `if` checks followed by `revert` and custom errors from `Errors.sol` - Implemented specific custom errors: - `InvalidArrayLength(uint256 expected, uint256 actual)` - `InvalidBooleanType()` - `ExpectedMajorByteString()` - `ExpectedNegativeBigNumTag()` - `ExpectedLowValue27()` - Ensured proper import of `Errors.sol` across relevant CBOR modules - Preserved original indentation and code formatting for readability - Improves error handling consistency and prevents `Panic` exceptions This change aligns with Solidity best practices by using custom errors for more efficient and descriptive error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip