Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

feat: collect and record Filecoin ID for all attempts #67

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 15, 2023

Need to have the Filecoin ID for all of the attempts too, so we can look at failures by Filecoin SPs.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #67 (f0cad10) into main (99de266) will increase coverage by 2.03%.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   21.16%   23.20%   +2.03%     
==========================================
  Files          10       10              
  Lines        1266     1280      +14     
==========================================
+ Hits          268      297      +29     
+ Misses        969      957      -12     
+ Partials       29       26       -3     
Files Changed Coverage Δ
metrics/events.go 0.00% <0.00%> (ø)
eventrecorder/recorder.go 46.42% <82.97%> (+2.81%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a tiny bit of anxiety about the volume this server handles and whether this will cause a choke waiting for all the hey fil calls coming back, but let's give it a go and see first.

@rvagg rvagg merged commit 5963abf into main Aug 15, 2023
11 checks passed
@rvagg rvagg deleted the rvagg/filspid_for_attempts branch August 15, 2023 23:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants