This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat: force packing if threshold is not reached after a configurable duration #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default duration is 24h.
this PR doesn't introduce a test (yet?). i've only verified its function by looking at logs so far.
i'm thinking about how this could be tested. maybe could add a routine to the beginning of the integration test file that ensures no pack jobs have run yet, then post a small amount of data below the threshold, wait a bit longer than the configured timeout (set to 5 seconds for the test, or something like that), and then check that a pack job has run.
thoughts? i haven't looked into whether it's possible / how to inspect pack jobs yet
Fixes #169