Add --recreateStationIdOnError
#563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested changes
Aug 1, 2024
bajtos
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
👌🏻
What do you think about improving the following error message to explain to the user that they can re-run Station Core with the new flag to fix the problem?
Line 64 in fe02c6e
|
Great idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For filecoin-station/desktop#1726
I decided to add this flag instead of a new exit code (as suggested in filecoin-station/desktop#1726 (comment)), because with the new exit code Station Desktop needs to know where Station Core stores its internal files, and this coupling isn't necessary.