Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Add pass DEPLOYMENT_TYPE #714

Merged
merged 3 commits into from
May 26, 2023
Merged

core: Add pass DEPLOYMENT_TYPE #714

merged 3 commits into from
May 26, 2023

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber requested a review from bajtos May 22, 2023 09:36
@juliangruber juliangruber mentioned this pull request May 22, 2023
Merged
@bajtos
Copy link
Member

bajtos commented May 25, 2023

@juliangruber I think you need to rework this PR to use a different env var: DEPLOYMENT_TYPE

bajtos
bajtos approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the env var name & value. The PR looks good otherwise.

@juliangruber juliangruber merged commit f6bf7ae into main May 26, 2023
@juliangruber juliangruber deleted the add/telemetry-running-in-station-desktop branch May 26, 2023 10:41
@bajtos bajtos changed the title core: Add pass RUNNING_IN_STATION_DESKTOP core: Add pass DEPLOYMENT_TYPE May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos