fix: object diff when assertion failed #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose `Deno.inspect` as `Zinnia.inspect`.
Fix the error message printed by assertion functions to describe object
properties.
Before this fix:
```
error: Uncaught AssertionError: Values are not equal.
[Diff] Actual / Expected
"[object Object]"
at assertEquals (ext:zinnia_runtime/vendored/asserts.bundle.js:479:11)
```
After the fix:
```
error: Uncaught AssertionError: Values are not equal.
[Diff] Actual / Expected
{
- foo: "bar",
+ foo: "123",
}
at assertEquals (ext:zinnia_runtime/vendored/asserts.bundle.js:495:11)
```
Signed-off-by: Miroslav Bajtoš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
Deno.inspectasZinnia.inspect.Fix the error message printed by assertion functions to describe object properties.
Before this fix:
After the fix:
I noticed the problem while working on filecoin-station/spark#46