Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Removed Vanara from DriveHelpers #16091

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Code Quality: Removed Vanara from DriveHelpers #16091

merged 3 commits into from
Sep 29, 2024

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Aug 27, 2024 •
edited
Loading

Resolved / Related Issues

Steps used to test these changes

  1. Set a long drive label
  2. See it in Files properly shown

@0x5bfa 0x5bfa changed the title Code Quality: Removed DrivesViewModel and introduce merged DeviceWatcher Code Quality: Removed DrivesViewModel and introduced IDeviceWatcher Aug 27, 2024
@0x5bfa 0x5bfa changed the title Code Quality: Removed DrivesViewModel and introduced IDeviceWatcher Code Quality: Introduced IStorageDevicesService Sep 12, 2024
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-IStorageDevicesService branch from 5b8e2ac to b4faf6c Compare September 24, 2024 22:26
@0x5bfa
Init
0232f7a 
Revert "Init"

This reverts commit f238f71.

Init

Remove Vanara from DriveHelpers

Revert "Init"

This reverts commit 9cfee93.

Init

Update comments

Update
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-IStorageDevicesService branch from 153ec26 to 0232f7a Compare September 24, 2024 22:33
@0x5bfa 0x5bfa changed the title Code Quality: Introduced IStorageDevicesService Code Quality: Remove Vanara from DriveHelpers Sep 24, 2024
@0x5bfa 0x5bfa changed the title Code Quality: Remove Vanara from DriveHelpers Code Quality: Removed Vanara from DriveHelpers Sep 24, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 26, 2024
@yaira2 yaira2 merged commit 2c84ab9 into files-community:main Sep 29, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-IStorageDevicesService branch September 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2