Added new label instance which can handle n numbers of keys and values #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added global vector register so access vectors globally
fimad
reviewed
May 10, 2019
| @@ -23,11 +27,15 @@ import qualified Control.Concurrent.STM as STM | |||
| -- | A 'Registry' is a list of all registered metrics, currently represented by | |||
| -- their sampling functions. | |||
| type Registry = [IO [SampleGroup]] | |||
| type VectorRegistry l m = [IO [(l,(Vector l m))]] | |||
There was a problem hiding this comment.
What does the vector registry provide that the standard registry does not?
| @@ -32,6 +32,9 @@ type Label0 = () | |||
| instance Label () where | |||
| labelPairs () () = [] | |||
|
|
|||
| instance Label [Text] where | |||
There was a problem hiding this comment.
The downside to using a list is that you don't get compile time checking that the number of values match the number of labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added global vector register so access vectors globally