Merge pull request #63 from finestructure/allow-numbers-in-branch-name

Allow numbers in branch name
finestructure · Aug 28, 2020 · 9d350ab · 9d350ab
2 parents 5f6dd70 + 7c99c12
commit 9d350ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Sources/ArenaCore/Parser+ext.swift b/Sources/ArenaCore/Parser+ext.swift
@@ -12,7 +12,7 @@ import SemanticVersion
 
 
 // https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html
-let AllowedBranchCharacters = CharacterSet.letters.union(CharacterSet(charactersIn: ".-@/"))
+let AllowedBranchCharacters = CharacterSet.alphanumerics.union(CharacterSet(charactersIn: ".-@/"))
 let AllowedStartBranchCharacters = AllowedBranchCharacters.subtracting(CharacterSet(charactersIn: "/"))
 let AllowedEndBranchCharacters = AllowedBranchCharacters.subtracting(CharacterSet(charactersIn: "/."))
 

diff --git a/Tests/ArenaTests/ParserTests.swift b/Tests/ArenaTests/ParserTests.swift
@@ -62,6 +62,11 @@ class ParserTests: XCTestCase {
         XCTAssertEqual(branchName.run("foo/"), Match(result: nil, rest: "foo/"))
     }
 
+    func test_parse_branchName_v5() throws {
+        // Test for issue https://github.com/finestructure/Arena/issues/62
+        XCTAssertEqual(branchName.run("v5-develop"), Match(result: "v5-develop", rest: ""))
+    }
+
     func test_parse_branch() {
         XCTAssertEqual(Parser.branch.run("@branch:develop"), Match(result: .branch("develop"), rest: ""))
     }