Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMSI-751: Add the confidence field to VPN response #141

Merged
merged 6 commits into from
Sep 25, 2024
Merged

SMSI-751: Add the confidence field to VPN response #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b0744b
add the confidence field to VPN response
soniabhishek Sep 16, 2024
b5a8eeb
Update schemas/components/schemas/VpnResult.yaml
soniabhishek Sep 24, 2024
665ee8b
Update schemas/components/schemas/VpnResult.yaml
soniabhishek Sep 24, 2024
4f247a5
add confidence to the required field
soniabhishek Sep 24, 2024
0b8506e
chore: add changeset
TheUnderScorer Sep 25, 2024
95d89fc
Update .changeset/orange-taxis-fetch.md
soniabhishek Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-taxis-fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'fingerprint-pro-server-api-openapi': minor
---

**visitors**: Add the confidence field to the VPN Detection Smart Signal
7 changes: 7 additions & 0 deletions schemas/components/schemas/VpnResult.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,14 @@ properties:
- publicVPN
- auxiliaryMobile
- osMismatch
confidence:
type: string
soniabhishek marked this conversation as resolved.
Show resolved Hide resolved
enum: [low, medium, high]
description: >-
ilfa marked this conversation as resolved.
Show resolved Hide resolved
A confidence rating for the VPN detection result — "low", "medium", or "high". Depends on the combination of results returned from all VPN detection methods.
example: low
required:
JuroUhlar marked this conversation as resolved.
Show resolved Hide resolved
- result
- originTimezone
- methods
- confidence
3 changes: 2 additions & 1 deletion schemas/paths/examples/get_event_200.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@
"publicVPN": false,
"auxiliaryMobile": false,
"osMismatch": false
}
},
"confidence": "high"
}
},
"proxy": {
Expand Down
3 changes: 2 additions & 1 deletion schemas/paths/examples/webhook.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@
"publicVPN": false,
"auxiliaryMobile": false,
"osMismatch": false
}
},
"confidence": "high"
},
"proxy": {
"result": false
Expand Down