Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64/aarch64 build fixes for nettle7 and libid3tag #962

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dhomeier
Copy link
Contributor

Separating the packages addressed in #952 out here.
libid3tag works as proposed with updated config.guess (tested on old 10.14 installation with fink 0.45 and dpkg 1.10.21 as well). Both are building as aarch64-apple-darwin... now.
nettle8 from ab0978d builds without further changes.

@dhomeier dhomeier added the arm64 Build issues and fixes for Apple Silicon label Jan 28, 2023
@dhomeier dhomeier mentioned this pull request Jan 28, 2023
@TheSin-
Copy link
Member

TheSin- commented Jan 28, 2023

I think the nettle7 fix is likely the best option. I'll have to cherry pick it though cause I'm not going to test libid3tag. Hopefully I'll get it in today as I need to get python27 in today

@dhomeier dhomeier requested review from sth0 and removed request for nieder January 28, 2023 22:26
Copy link
Contributor

@sth0 sth0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheSin-
Copy link
Member

TheSin- commented Jan 29, 2023

Seems, this isn't enough

/usr/bin/install -d -m 755 /opt/sw/src/fink.build/root-nettle7-3.5.1-3/opt/sw/share
/bin/mv /opt/sw/src/fink.build/root-nettle7-shlibs-3.5.1-3/opt/sw/share/info /opt/sw/src/fink.build/root-nettle7-3.5.1-3/opt/sw/share/
mv: rename /opt/sw/src/fink.build/root-nettle7-shlibs-3.5.1-3/opt/sw/share/info to /opt/sw/src/fink.build/root-nettle7-3.5.1-3/opt/sw/share/info: No such file or directory

seems a missing dep maybe? I'm looking into it.

  Documentation:     no
checking for makeinfo... not-found

need a BD on texinfo

Once tested I'll commit nettle7 with this patch and the BD addition

@dhomeier
Copy link
Contributor Author

need a BD on texinfo

Ah, of course; same as for nettle8 (at least on Ventura, <= 12.x still has its own makeinfo, but better to use the same build everywhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm64 Build issues and fixes for Apple Silicon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants