fix: ELECTRON-1505 (Prevent opening links longer than 2083) (#775)

* ELECTRON-1505 - Prevent opening links longer than 2083 * ELECTRON-1505 - Prevent opening links longer than 2083
finos · Aug 30, 2019 · de5a60f · de5a60f
1 parent 85928f4
commit de5a60f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/app/child-window-handler.ts b/src/app/child-window-handler.ts
@@ -193,13 +193,13 @@ export const handleChildWindow = (webContents: WebContents): void => {
                 }
             });
         } else {
+            event.preventDefault();
             if (newWinUrl && newWinUrl.length > 2083) {
                 logger.info(`child-window-handler: new window url length is greater than 2083, not performing any action!`);
                 return;
             }
             logger.info(`child-window-handler: new window url is ${newWinUrl} which is not of the same host,
             so opening it in the default browser!`);
-            event.preventDefault();
             windowHandler.openUrlInDefaultBrowser(newWinUrl);
         }
     };