enable etag on latest version by resolving latest #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannanGao-gs
force-pushed
the
latestEtag
branch
from
1a6ad30 to
c2a0f55
Compare
gs-gunjan
reviewed
Sep 25, 2024
...entities-api/src/main/java/org/finos/legend/depot/services/api/entities/EntitiesService.java
Outdated
Show resolved
Hide resolved
YannanGao-gs
force-pushed
the
latestEtag
branch
2 times, most recently
from
5c64670 to
801d44d
Compare
YannanGao-gs
force-pushed
the
latestEtag
branch
from
801d44d to
fa99284
Compare
|
looks good to me |
...ies-services/src/test/java/org/finos/legend/depot/server/resources/TestEntitiesResource.java
Show resolved
Hide resolved
|
why didnt we also fix the other apis that use latest such as the dependnecy entities api ? |
MauricioUyaguari
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable etag on latest version by resolving latest