Merge pull request #2350 from finos/tkp/examples

Update webpack dev server configuration options, fixes for perspective 2.0+
finos · Aug 31, 2023 · bec2442 · bec2442
2 parents 71321bc + 436214f
commit bec2442
Show file tree

Hide file tree

Showing 7 changed files with 22 additions and 6 deletions.
diff --git a/examples/promo/webpack.config.js b/examples/promo/webpack.config.js
@@ -44,7 +44,7 @@ module.exports = {
         ],
     },
     devServer: {
-        contentBase: [
+        static: [
             path.join(__dirname, "dist"),
             path.join(__dirname, "../../node_modules/superstore-arrow"),
         ],

diff --git a/examples/workspace-editing-python/src/index.js b/examples/workspace-editing-python/src/index.js
@@ -12,6 +12,7 @@
 
 import perspective from "@finos/perspective";
 import "@finos/perspective-workspace";
+import "@finos/perspective-viewer";
 import "@finos/perspective-viewer-datagrid";
 import "@finos/perspective-viewer-d3fc";
 

diff --git a/examples/workspace-editing-python/src/index.less b/examples/workspace-editing-python/src/index.less
@@ -11,6 +11,7 @@
 // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
 
 @import "~@finos/perspective-workspace/dist/theme/pro.less";
+@import "~@finos/perspective-viewer/dist/css/themes.css";
 
 body {
   display: flex;

diff --git a/examples/workspace-editing-python/webpack.config.js b/examples/workspace-editing-python/webpack.config.js
@@ -44,7 +44,7 @@ module.exports = {
         ],
     },
     devServer: {
-        contentBase: [
+        static: [
             path.join(__dirname, "dist"),
             path.join(__dirname, "../../node_modules/superstore-arrow"),
         ],

diff --git a/examples/workspace/src/index.js b/examples/workspace/src/index.js
@@ -12,6 +12,7 @@
 
 import perspective from "@finos/perspective";
 import "@finos/perspective-workspace";
+import "@finos/perspective-viewer";
 import "@finos/perspective-viewer-datagrid";
 import "@finos/perspective-viewer-d3fc";
 
@@ -37,18 +38,30 @@ const DEFAULT_LAYOUT = {
         },
     },
     viewers: {
-        One: { table: "superstore", editable: true },
+        One: {
+            table: "superstore",
+            title: "Test Widget I",
+            editable: true,
+            linked: true,
+        },
+        Two: {
+            table: "superstore",
+            title: "Test Widget II (modified)",
+            linked: true,
+        },
         Three: {
             table: "superstore",
-            name: "Test Widget III (modified)",
+            title: "Test Widget III (modified)",
             group_by: ["State"],
             columns: ["Sales", "Profit"],
+            linked: true,
         },
         Four: {
             table: "superstore",
-            name: "Test Widget IV (modified)",
+            title: "Test Widget IV (modified)",
             group_by: ["Category", "Sub-Category"],
             columns: ["Sales", "Profit"],
+            linked: true,
         },
     },
 };

diff --git a/examples/workspace/src/index.less b/examples/workspace/src/index.less
@@ -11,6 +11,7 @@
 // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
 
 @import "~@finos/perspective-workspace/dist/css/pro-dark.css";
+@import "~@finos/perspective-viewer/dist/css/themes.css";
 
 body {
     display: flex;

diff --git a/examples/workspace/webpack.config.js b/examples/workspace/webpack.config.js
@@ -49,7 +49,7 @@ module.exports = {
         ],
     },
     devServer: {
-        contentBase: [
+        static: [
             path.join(__dirname, "dist"),
             path.join(__dirname, "../../node_modules/superstore-arrow"),
         ],