Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace type equality check with isinstance check #2320

Closed
wants to merge 1 commit into from
Closed

replace type equality check with isinstance check #2320

wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Member

Small fix to something now flagged by flake8, dont do a type(…) == <type>, do a isinstance(…, <type>)

@timkpaine timkpaine added the internal Internal refactoring and code quality improvement label Jul 31, 2023
@timkpaine timkpaine requested a review from texodus August 2, 2023 14:06
@texodus
Copy link
Member

texodus commented Aug 2, 2023

Closing for #2323 which pins these dependencies.

da9a7bb

@texodus texodus closed this Aug 2, 2023
@timkpaine timkpaine deleted the tkp/isinstance branch August 11, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@texodus texodus Awaiting requested review from texodus

Assignees
No one assigned
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus