Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows 2019 from CI #2333

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Remove Windows 2019 from CI #2333

merged 1 commit into from
Aug 13, 2023

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Aug 9, 2023

Removes the Windows 2019 targets from CI and publish steps, deferring to the existing but unused 2022 builds.

@timkpaine timkpaine changed the title prune win 2019 prune win 2019 from ci, switch over to windows-2022 only Aug 9, 2023
@timkpaine timkpaine added the internal Internal refactoring and code quality improvement label Aug 9, 2023
@texodus
Copy link
Member

texodus commented Aug 13, 2023

@timkpaine Is this a draft or not?

full build

@timkpaine
Copy link
Member Author

timkpaine commented Aug 13, 2023

I wanted to make sure the full build ran, but it was failing due to the usual reasons (unrelated to this PR, though this PR will hopefully help). If the full build passes (and/or the only failures are the current known network / one tornado test) then its good to go

@timkpaine timkpaine marked this pull request as ready for review August 13, 2023 20:07
@texodus
Copy link
Member

texodus commented Aug 13, 2023

full build

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus merged commit cf17658 into master Aug 13, 2023
115 of 119 checks passed
@texodus texodus deleted the tkp/trimci branch August 13, 2023 20:10
@texodus texodus changed the title prune win 2019 from ci, switch over to windows-2022 only Remove Windows 2019 from CI Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants