Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let themes control select and option colors #2400

Closed
wants to merge 1 commit into from

Conversation

wjackson
Copy link

This is a fix for #2369.

Copy link
Contributor

@ada-x64 ada-x64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on my Manjaro Linux machine, can confirm that the changes fix the bug. LGTM! cc @texodus

@texodus
Copy link
Member

texodus commented Nov 9, 2023

Thanks for the PR @wjackson!

Adding new CSS variables for these properties requires this variable to be specified for all themes, as you've noticed. As there is not compelling reason to style option background in isolation, this shouldn't be public (or at the very least, should default to the themes' palette).

I can't test this as its a Windows bug (not a Chrome bug as the Issue says), but I've added this default in #2422 anyway, closing

@texodus texodus closed this Nov 9, 2023
@wjackson
Copy link
Author

there is not compelling reason to style option background in isolation

Yeah that makes sense.

I can't test this as its a Windows bug (not a Chrome bug as the Issue says), but I've added this default in #2422

The screenshots in #2369 came from Chrome on Linux so it's not a Windows bug. As mentioned in the issue, I tested for and found the bug on a couple different Linuxes and Windows.

I tested your fix (upgrade-emsdk:017b3d301) on Linux where I originally found the bug and it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants