Upgrade pyodide compatibility to v0.24.1

[tomjakubowski]

No description provided.

[tomjakubowski]

Failing the same way on my Mac laptop.

running build_ext
configure: cmake -DCMAKE_C_COMPILER=/tmp/tmpk5cylkyn/cc -DCMAKE_CXX_COMPILER=/tmp/tmpk5cylkyn/c++ -DCMAKE_AR=/tmp/tmpk5cylkyn/ar -DCMAKE_C_COMPILER_AR=/tmp/tmpk5cylkyn/ar -DCMAKE_CXX_COMPILER_AR=/tmp/tmpk5cylkyn/ar --fresh --version -DCMAKE_CROSSCOMPILING_EMULATOR=/home/runner/work/_temp/64c13a07-2a13-4db9-85db-5254e1118b1b/emsdk-main/node/16.20.0_64bit/bin/node
configure: cmake -DCMAKE_C_COMPILER=/tmp/tmpk5cylkyn/cc -DCMAKE_CXX_COMPILER=/tmp/tmpk5cylkyn/c++ -DCMAKE_AR=/tmp/tmpk5cylkyn/ar -DCMAKE_C_COMPILER_AR=/tmp/tmpk5cylkyn/ar -DCMAKE_CXX_COMPILER_AR=/tmp/tmpk5cylkyn/ar --fresh /home/runner/work/perspective/perspective/python/perspective/dist -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/runner/work/perspective/perspective/python/perspective/build/lib.emscripten_3_1_45_wasm32-cpython-311/perspective/table -DCMAKE_BUILD_TYPE=Release -DPSP_CPP_BUILD=1 -DPSP_WASM_BUILD=0 -DPSP_PYTHON_BUILD=1 -DPSP_PYTHON_VERSION=3.11 -DPython_ADDITIONAL_VERSIONS=3.11 -DPython_FIND_VERSION=3.11 -DPython_EXECUTABLE=/tmp/build-env-o61j6l19/bin/python -DPYTHON_LIBRARY=/root/repo/cpython/installs/python-3.11.3/lib -DPYTHON_INCLUDE_DIR=/root/repo/cpython/installs/python-3.11.3/include/python3.11 -DPython_ROOT_DIR=/tmp/build-env-o61j6l19 -DPython_ROOT=/tmp/build-env-o61j6l19 -DPSP_CMAKE_MODULE_PATH=/home/runner/work/perspective/perspective/python/perspective/dist/cmake -DPSP_CPP_SRC=/home/runner/work/perspective/perspective/python/perspective/dist -DPSP_PYTHON_SRC=/home/runner/work/perspective/perspective/python/perspective/dist/../perspective -DCMAKE_BUILD_TYPE=Release -DCMAKE_CROSSCOMPILING_EMULATOR=/home/runner/work/_temp/64c13a07-2a13-4db9-85db-5254e1118b1b/emsdk-main/node/16.20.0_64bit/bin/node
CMake Error at /opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/cmake/data/share/cmake-3.27/Modules/CMakeDetermineSystem.cmake:154 (message):
  Could not find toolchain file:
  /opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/pyodide_build/tools/cmake/Modules/Platform/Emscripten.cmake
Call Stack (most recent call first):
  CMakeLists.txt:2 (project)

Coming from line 2 of CMakeLists.txt. Not sure why it's looking under site-packages/pyodide_build for the toolchain file

[tomjakubowski]

the problem was pyodide/pyodide#4216

I was able to finish a build on my laptop, but it was a native .so for some reason. Building here while I debug locally, just in case it's a result of a quite dirty working tree.

[timkpaine]

this also changed? Is this durable to changes in setup-python?

[timkpaine]

ah meh # PYTHON_VERSION and EMSCRIPTEN_VERSION are determined by PYODIDE_VERSION.

[tomjakubowski]

all gucci?

[tomjakubowski]

unrelated change here --

I was rusty on perspective dev, used npm by mistake instead of yarn and, without the "new untracked file" cue in git status I didn't realize I had gone astray. Ended up with a busted node_modules directory from it

Of course we also don't want package-lock.json checked in. So I am happy to undo this, just wanted to raise the issue. Maybe there is a better way to help people like me avoid using npm in perspective dev

[texodus]

Thanks for the PR! Looks good!

I want to spend more time understanding the emscripten dependency of this build, specifically whether we are over-installing or over-building it.