Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements regenerator script and action #2413

Closed
wants to merge 2 commits into from
Closed

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Nov 4, 2023

This PR does 3 things

  • Add helper script for regenerating python frozen dependencies. We want CI to be stable, but we also need to move dependencies forward, so hopefully this will help with that. This change also comes with some slight refactoring.
  • Add a github workflow for doing bullet 1 across all python versions, so we don't need to rely on having all pythons installed locally. It will push to a well-known branch name tkp/update-frozen-python-dependencies, which we can then PR to master
  • Uses bullet 1 to update all deps, in a second commit

From my fork:

Screenshot 2023-11-04 at 16 36 20 Screenshot 2023-11-04 at 17 47 37 Screenshot 2023-11-04 at 18 09 10

@timkpaine timkpaine added internal Internal refactoring and code quality improvement and removed cla-present labels Nov 4, 2023
@timkpaine timkpaine force-pushed the tkp/pydeps branch 2 times, most recently from 0a51729 to f67c9db Compare November 4, 2023 20:56
@timkpaine timkpaine marked this pull request as ready for review November 4, 2023 21:54
@texodus
Copy link
Member

texodus commented Nov 9, 2023

Thanks for the PR!

I understand why you want to upgrade the CI deps, but I don't want this (or any dev task) done on CI. These resources are of limited availability, slow, prone to environmental regressions and extremely hard to debug/develop against locally.

I've added a pip method for regenerating these files in #2422 you can try to use as an alternative.

@texodus texodus closed this Nov 9, 2023
@timkpaine
Copy link
Member Author

I don't have python 3.8, 3.9, or 3.10 installed locally, does the script handle installing those python versions?

@timkpaine timkpaine deleted the tkp/pydeps branch July 4, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants