API Versioning + Migration #2430
Conversation
ada-x64
force-pushed
the
features/api-versioning
branch
from
29edbb9 to
870b2f1
Compare
There was a problem hiding this comment.
Thanks for the PR! Looks good!
It should be noted that versioning in this change is runtime-transparent, the version field is not read or validated in any way by <perspective-viewer> at runtime, only in wrt the migration script. IMO we either need to warn on all deprecated versions, or at least specifically warn of the version when a restore() call fails in addition to the actual error.
The dev notes are not correct, but I will update these.
| ``` | ||
|
|
||
| `perspective-python` supports Python 3.8 and upwards. | ||
|
|
There was a problem hiding this comment.
yarn _requires_python is the correct way to do this. While this is not documented, a good place to look is always the CI actions yaml
| yarn build | ||
| yarn setup # choose javascript > jupyterlab | ||
| yarn build | ||
| yarn jlab_link # run this whenever you need to update a local perspective package |
There was a problem hiding this comment.
This doesn't actually work due to a bug. yarn jlab_link currently installs perspective-python in your virtual env, including the python and C++ extension, so further rebuilds in your source repo won't get picked up.
Based on #2429
This PR adds versioning to the perspective viewer's save/restore API.
It also adds a new format for migrations and adds migrations for the new expression and X/Y scatter symbol serialization formats.