fix: Doctype in html export #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox throws a warning > Bogus doctype.Quirky doctype. Expected “<!DOCTYPE html>”. Signed-off-by: asrar <[email protected]>
texodus
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thanks for the PR! Looks good!
Normally, I'd ask for a test for something like this, especially because this is a noted prerequisite for official Firefox support, but this is obviously invalid HTML and this is the only occurring instance in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox throws a warning