Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Multi Chart" that allows mix-and-match of different series types #586

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

andy-lee-eng
Copy link
Contributor

This PR is a PoC and depends on PR #581. I thought I'd offer it this way so you can get a look at it and provide any feedback. Once #581 has been completed, we can re-do this as a PR into master.

The "Multi Chart" behaves much like the "Y Bar Chart", "Y Line Chart", "Y Area Chart" and "Y Scatter Chart", but can use series types from any of the above.

image

Notice the line/bar chart icons underneath the two y-axes. Clicking on them will cycle through the available series types for that axis (line/bar/area/scatter). The chosen series types will be remembered in "settings" if you save and load.

This chart reproduces a lot of the features of the other 4 charts (though is not quite identical), so I'm not sure how best to introduce it. Matt suggested maybe we could get rid of the other 4 charts, and provide a mapping function to this chart. For example, if someone is restoring a saved "Y Line Chart", we could instead show a "Multi Chart" with the "line" series selected.

@andy-lee-eng andy-lee-eng requested a review from texodus May 20, 2019 10:20
@timkpaine timkpaine added development enhancement Feature requests or improvements JS labels May 26, 2019
Initially just does line and bar series.
Refactored to allow re-use of line/bar specific data and series code
Refactored to increase flexibility of chart and splitter functionality
Legend position is preserved when the chart structure changes.
@andy-lee-eng andy-lee-eng changed the base branch from DevAndyLee-feature/dual-y-other-charts to master May 27, 2019 08:21
@andy-lee-eng
Copy link
Contributor Author

Rebased on master

@texodus texodus marked this pull request as draft October 7, 2020 08:56
@davisford
Copy link

This looks pretty slick. Wondering if there are plans to push this through? Seems like the PR it was waiting on has been merged.

@RajaPoseidon
Copy link

RajaPoseidon commented May 15, 2024

this is a useful , having multi type chart . Will it be available soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants