make sure array-data-source send rows to client on subscribe (#1492)

* make sure array-data-source send rows to client on subscribe * upgrade deprecated github upload action
finos · Sep 13, 2024 · 281e4d2 · 281e4d2
1 parent 9efda62
commit 281e4d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/cve-scanning.yml b/.github/workflows/cve-scanning.yml
@@ -29,7 +29,7 @@ jobs:
             --enableRetired
       - name: Upload Test results
         if: ${{ always() }}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: Depcheck report
           path: ${{ github.workspace }}/reports
diff --git a/vuu-ui/packages/vuu-data-local/src/array-data-source/array-data-source.ts b/vuu-ui/packages/vuu-data-local/src/array-data-source/array-data-source.ts
@@ -49,6 +49,7 @@ import {
   DataSourceConfigChanges,
   selectionCount,
   isEditCellRequest,
+  rangesAreSame,
 } from "@finos/vuu-utils";
 import { aggregateData } from "./aggregate-utils";
 import { buildDataToClientMap, toClientRow } from "./array-data-utils";
@@ -238,7 +239,7 @@ export class ArrayDataSource
         type: "viewport-update",
         size: this.#data.length,
       });
-      if (range) {
+      if (range && !rangesAreSame(this.#range, range)) {
         this.range = range;
       } else if (this.#range !== NULL_RANGE) {
         this.sendRowsToClient();