Skip to content

Commit

Permalink
Pull request #409: remove unused imports, and change test assertion bug
Browse files Browse the repository at this point in the history
Merge in WALTZ/waltz from WALTZ/waltz-sj:CTCTOWALTZ-3415-variable-reference-issue-3 to db-feature/entity-relationship-variable-ref-fix-7175

* commit 'a1c6fa6c3093c78d5227e5a6c90994068fc224c0':
  remove unused imports, and change test assertion bug
  • Loading branch information
jain-shreyans-db committed Oct 21, 2024
2 parents 5899573 + a1c6fa6 commit 42afe49
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package org.finos.waltz.integration_test.inmem.service;

import com.sun.org.slf4j.internal.Logger;
import com.sun.org.slf4j.internal.LoggerFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.finos.waltz.common.SetUtilities;
import org.finos.waltz.common.StringUtilities;
import org.finos.waltz.integration_test.inmem.BaseInMemoryIntegrationTest;
Expand All @@ -15,7 +15,6 @@
import org.finos.waltz.model.rel.ImmutableRelationshipKind;
import org.finos.waltz.model.rel.RelationshipKind;
import org.finos.waltz.model.user.SystemRole;
import org.finos.waltz.service.app_group.AppGroupService;
import org.finos.waltz.service.application.ApplicationService;
import org.finos.waltz.service.entity_relationship.BulkUploadRelationshipService;
import org.finos.waltz.service.entity_relationship.EntityRelationshipService;
Expand All @@ -29,7 +28,6 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;

import static java.lang.String.format;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ void simpleTSV() {
*/
BulkUploadRelationshipParsedResult result = parser.parse(readTestFile("test-relationship-item.tsv"), BulkUploadRelationshipItemParser.InputFormat.TSV);
assertEquals(null, result.error());
assertEquals(2, result.parsedItems().size());
assertEquals(3, result.parsedItems().size());

Set<String> sourceExternalIds = SetUtilities.map(result.parsedItems(), BulkUploadRelationshipItem::sourceExternalId);
assertEquals(sourceExternalIds, SetUtilities.asSet("sourceExtA", "sourceExtB", "sourceExtC"));
Expand Down

0 comments on commit 42afe49

Please sign in to comment.