Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user record changes for getAccountInfo() #2341

Merged
merged 9 commits into from
Apr 3, 2024
Merged

user record changes for getAccountInfo() #2341

merged 9 commits into from
Apr 3, 2024

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Oct 18, 2023 •
edited
Loading

Since PasskeyInfo is only enrolled via client SDK for the users and we can only GET enrolled passkeys, integration testing is not possible here.
Manually tested

getAuth().getUser(<UID>).then((user) => console.log(user.passkeyInfo));

for a user with enrolled passkeys printed :

passkeyInfo: [
    PasskeyInfo {
      name: 'Unnamed account (Web)',
      credentialId: '<CREDENTIALS>',
      displayName: ''
    }
  ]

@pragatimodi pragatimodi marked this pull request as draft October 18, 2023 22:57
@pragatimodi pragatimodi requested a review from renkelvin October 20, 2023 23:22
@pragatimodi pragatimodi marked this pull request as ready for review October 20, 2023 23:32
kevinthecheung
kevinthecheung approved these changes Oct 20, 2023
View reviewed changes
src/auth/user-record.ts Outdated Show resolved Hide resolved
src/auth/user-record.ts Outdated Show resolved Hide resolved
renkelvin
renkelvin approved these changes Oct 23, 2023
View reviewed changes
Copy link

@renkelvin renkelvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 issue.

src/auth/user-record.ts Outdated Show resolved Hide resolved
Xiaoshouzi-gh
Xiaoshouzi-gh approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit comments

src/auth/user-record.ts Outdated Show resolved Hide resolved
test/unit/auth/user-record.spec.ts Show resolved Hide resolved
@pragatimodi pragatimodi merged commit 041bf17 into passkeys Apr 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renkelvin renkelvin renkelvin approved these changes

@Xiaoshouzi-gh Xiaoshouzi-gh Xiaoshouzi-gh approved these changes

@kevinthecheung kevinthecheung kevinthecheung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pragatimodi @renkelvin @kevinthecheung @Xiaoshouzi-gh