Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update firebase sdks to depend on the new version of common #5419

Merged
merged 4 commits into from
Oct 13, 2023
Merged

update firebase sdks to depend on the new version of common #5419

merged 4 commits into from
Oct 13, 2023

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@VinayGuthal VinayGuthal requested a review from rlazo October 13, 2023 17:41
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Unit Test Results

     936 files  +     890       936 suites  +890   39m 21s ⏱️ + 37m 59s
  5 096 tests +  5 030    5 075 ✔️ +  5 009  21 💤 +21  0 ❌ ±0 
10 277 runs  +10 129  10 235 ✔️ +10 087  42 💤 +42  0 ❌ ±0 

Results for commit a551444. ± Comparison against base commit b63cf96.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.94 MB1.94 MB-412 B (-0.0%)

  • firebase-appcheck-debug

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)372 kB372 kB-4 B (-0.0%)
    apk (release)1.95 MB1.95 MB-472 B (-0.0%)

  • firebase-appcheck-debug-testing

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.02 MB2.02 MB-180 B (-0.0%)

  • firebase-appcheck-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.94 MB1.94 MB-284 B (-0.0%)

  • firebase-appcheck-playintegrity

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.96 MB1.96 MB-456 B (-0.0%)

  • firebase-appcheck-safetynet

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.96 MB1.96 MB-592 B (-0.0%)

  • firebase-appdistribution

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.66 MB2.66 MB+8 B (+0.0%)

  • firebase-appdistribution-api

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)125 kB125 kB+4 B (+0.0%)
    apk (release)1.65 MB1.65 MB-580 B (-0.0%)

  • firebase-appdistribution-api-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.65 MB1.65 MB-288 B (-0.0%)

  • firebase-common

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    aar96.0 kB96.0 kB+8 B (+0.0%)
    apk (aggressive)124 kB124 kB+4 B (+0.0%)

  • firebase-common-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.64 MB1.64 MB-4 B (-0.0%)

  • firebase-config

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)162 kB161 kB-4 B (-0.0%)
    apk (release)1.71 MB1.71 MB-464 B (-0.0%)

  • firebase-config-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.71 MB1.71 MB-380 B (-0.0%)

  • firebase-crashlytics

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.18 MB2.18 MB-664 B (-0.0%)

  • firebase-crashlytics-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.18 MB2.18 MB-364 B (-0.0%)

  • firebase-database

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.11 MB2.11 MB-560 B (-0.0%)

  • firebase-database-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.12 MB2.12 MB-528 B (-0.0%)

  • firebase-dynamic-links

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.94 MB1.94 MB-532 B (-0.0%)

  • firebase-dynamic-links-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.95 MB1.95 MB-612 B (-0.0%)

  • firebase-firestore

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)4.35 MB4.35 MB-352 B (-0.0%)

  • firebase-firestore-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)4.35 MB4.35 MB-416 B (-0.0%)

  • firebase-functions

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.20 MB2.20 MB-264 B (-0.0%)

  • firebase-functions-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)409 kB409 kB+4 B (+0.0%)
    apk (release)2.20 MB2.20 MB-508 B (-0.0%)

  • firebase-inappmessaging

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)4.34 MB4.34 MB-444 B (-0.0%)

  • firebase-inappmessaging-display

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)5.60 MB5.59 MB-568 B (-0.0%)

  • firebase-inappmessaging-display-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)1.55 MB1.55 MB+4 B (+0.0%)
    apk (release)5.60 MB5.60 MB-900 B (-0.0%)

  • firebase-inappmessaging-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)4.34 MB4.34 MB-456 B (-0.0%)

  • firebase-installations

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.67 MB1.67 MB-328 B (-0.0%)

  • firebase-installations-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.67 MB1.67 MB-696 B (-0.0%)

  • firebase-messaging

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)474 kB474 kB-4 B (-0.0%)
    apk (release)2.11 MB2.11 MB-688 B (-0.0%)

  • firebase-messaging-directboot

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)474 kB474 kB-4 B (-0.0%)
    apk (release)2.11 MB2.11 MB-236 B (-0.0%)

  • firebase-messaging-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)474 kB474 kB-4 B (-0.0%)
    apk (release)2.11 MB2.11 MB-324 B (-0.0%)

  • firebase-ml-modeldownloader

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.80 MB1.80 MB-424 B (-0.0%)

  • firebase-ml-modeldownloader-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)178 kB178 kB-4 B (-0.0%)
    apk (release)1.80 MB1.80 MB-276 B (-0.0%)

  • firebase-perf

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)1.25 MB1.25 MB-4 B (-0.0%)
    apk (release)3.76 MB3.76 MB-644 B (-0.0%)

  • firebase-perf-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)3.77 MB3.77 MB-428 B (-0.0%)

  • firebase-sessions

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)2.07 MB2.07 MB+84 B (+0.0%)

  • firebase-storage

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (aggressive)373 kB373 kB-4 B (-0.0%)
    apk (release)1.99 MB1.99 MB-668 B (-0.0%)

  • firebase-storage-ktx

    TypeBase (b63cf96)Merge (7a6dda5)Diff
    apk (release)1.99 MB1.99 MB-788 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hSboArIc17.html

@rlazo rlazo merged commit 406c057 into master Oct 13, 2023
@rlazo rlazo deleted the update_common_versions branch October 13, 2023 19:28
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.12% (b63cf96) to 50.18% (7a6dda5) by +0.07%.

    FilenameBase (b63cf96)Merge (7a6dda5)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    ViewProcessor.java91.79%92.10%+0.30%
    WriteTree.java76.67%77.22%+0.56%

  • firebase-firestore

    Overall coverage changed from 44.75% (b63cf96) to 44.76% (7a6dda5) by +0.00%.

    FilenameBase (b63cf96)Merge (7a6dda5)Diff
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dCZWlaMZ2a.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,619 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zyEwtcvrSt/index.html

@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinayGuthal @google-oss-bot @rlazo