Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e tests for Crashlytics #6559

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

test: add e2e tests for Crashlytics #6559

wants to merge 13 commits into from

Conversation

Lyokone
Copy link

@Lyokone Lyokone commented Dec 4, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 4, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (3dd8ddf) to 50.22% (16f6247) by +0.01%.

    FilenameBase (3dd8ddf)Merge (16f6247)Diff
    QueryParams.java89.76%90.36%+0.60%

  • firebase-firestore

    Overall coverage changed from 45.74% (3dd8ddf) to 45.73% (16f6247) by -0.00%.

    FilenameBase (3dd8ddf)Merge (16f6247)Diff
    SetMutation.java97.22%94.44%-2.78%

  • firebase-messaging

    Overall coverage changed from 84.08% (3dd8ddf) to 84.19% (16f6247) by +0.11%.

    FilenameBase (3dd8ddf)Merge (16f6247)Diff
    Metadata.java36.51%41.27%+4.76%

  • firebase-storage

    Overall coverage changed from ? (3dd8ddf) to 84.04% (16f6247) by ?.

    48 individual files with coverage change

    FilenameBase (3dd8ddf)Merge (16f6247)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?87.29%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    Storage.kt?39.58%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.69%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    TaskState.kt?0.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/s0vV8nqWF7.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Test Results

 1 038 files  + 27   1 038 suites  +27   34m 44s ⏱️ +26s
 5 874 tests ±  0   5 852 ✅ +  1  22 💤 ±0  0 ❌  - 1 
11 833 runs  +458  11 789 ✅ +458  44 💤 +1  0 ❌  - 1 

Results for commit cd29c76. ± Comparison against base commit 50eacb7.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 6, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (3dd8ddf) and merge commit (16f6247).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Owdzj7ifwm.html

Lyokone
Lyokone commented Dec 9, 2024
View reviewed changes
gradle/libs.versions.toml Outdated
Comment on lines 29 to 33
kotlinGradlePlugin = "1.9.24"
coreKtx = "1.15.0"
espressoCore = "3.6.1"
appcompat = "1.7.0"
material = "1.12.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should change the version here, probably worth keeping the PR bundled only for the Crashlytics Version, we can always make those changes in another PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be definitely changing this and making it local to the test app

MichaelVerdon
MichaelVerdon reviewed Dec 10, 2024
View reviewed changes
firebase-crashlytics/firebase-crashlytics.gradle
@@ -99,6 +99,8 @@ dependencies {
testImplementation(libs.robolectric)
testImplementation(libs.truth)
testImplementation(project(":integ-testing"))
testImplementation("io.mockk:mockk:1.13.8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be removed, was using to attempt to mock a few things but I found it was not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelVerdon MichaelVerdon MichaelVerdon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lyokone @google-oss-bot @MichaelVerdon