Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary LooperMode annotations #6605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unnecessary LooperMode annotations #6605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...ppdistribution/src/test/java/com/google/firebase/appdistribution/impl/AabUpdaterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.robolectric.Shadows.shadowOf;
import static org.robolectric.annotation.LooperMode.Mode.PAUSED;

import android.app.Activity;
import android.net.Uri;
Expand Down Expand Up @@ -54,11 +53,9 @@
import org.mockito.MockitoAnnotations;
import org.robolectric.Robolectric;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.LooperMode;
import org.robolectric.shadows.ShadowActivity;

@RunWith(RobolectricTestRunner.class)
@LooperMode(PAUSED)
public class AabUpdaterTest {
private static final String TEST_URL = "https://test-url";
private static final String REDIRECT_TO_PLAY = "https://redirect-to-play-url";
Expand Down
3 changes: 0 additions & 3 deletions ...base-messaging/src/test/java/com/google/firebase/messaging/FirebaseMessagingRoboTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.Config;
import org.robolectric.annotation.LooperMode;
import org.robolectric.annotation.LooperMode.Mode;
import org.robolectric.shadows.ShadowLooper;

/**
Expand All @@ -84,7 +82,6 @@
*/
@RunWith(RobolectricTestRunner.class)
@Config(shadows = ShadowPreconditions.class)
@LooperMode(Mode.PAUSED)
public final class FirebaseMessagingRoboTest {

private static final String INVALID_TOPIC = "@invalid";
Expand Down
3 changes: 0 additions & 3 deletions ...ssaging/src/test/java/com/google/firebase/messaging/FirebaseMessagingServiceRoboTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,9 @@
import org.robolectric.Robolectric;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.android.controller.ServiceController;
import org.robolectric.annotation.LooperMode;
import org.robolectric.annotation.LooperMode.Mode;
import org.robolectric.shadows.ShadowLooper;

@RunWith(RobolectricTestRunner.class)
@LooperMode(Mode.PAUSED)
public class FirebaseMessagingServiceRoboTest {

// Constants are copied so that tests will break if these change
Expand Down
2 changes: 0 additions & 2 deletions firebase-perf/src/test/java/com/google/firebase/perf/metrics/AppStartTraceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,10 @@
import org.mockito.stubbing.Answer;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.Config;
import org.robolectric.annotation.LooperMode;
import org.robolectric.shadows.ShadowSystemClock;

/** Unit tests for {@link AppStartTrace}. */
@RunWith(RobolectricTestRunner.class)
@LooperMode(LooperMode.Mode.PAUSED)
public class AppStartTraceTest extends FirebasePerformanceTestBase {

@Mock private Clock clock;
Expand Down
2 changes: 0 additions & 2 deletions firebase-perf/src/test/java/com/google/firebase/perf/util/FirstDrawDoneListenerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,9 @@
import org.mockito.InOrder;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.Config;
import org.robolectric.annotation.LooperMode;

/** Unit tests for {@link FirstDrawDoneListener}. */
@RunWith(RobolectricTestRunner.class)
@LooperMode(LooperMode.Mode.PAUSED)
public class FirstDrawDoneListenerTest {
private View testView;

Expand Down
3 changes: 0 additions & 3 deletions ...base-sessions/src/test/kotlin/com/google/firebase/sessions/SessionLifecycleServiceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,10 @@ import org.robolectric.Robolectric
import org.robolectric.RobolectricTestRunner
import org.robolectric.Shadows.shadowOf
import org.robolectric.android.controller.ServiceController
import org.robolectric.annotation.LooperMode
import org.robolectric.annotation.LooperMode.Mode.PAUSED
import org.robolectric.shadows.ShadowSystemClock

@OptIn(ExperimentalCoroutinesApi::class)
@MediumTest
@LooperMode(PAUSED)
@RunWith(RobolectricTestRunner::class)
internal class SessionLifecycleServiceTest {

Expand Down